Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: string trim set true for whole schema #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: string trim set true for whole schema #47

wants to merge 2 commits into from

Conversation

prashantk01
Copy link

  1. mongoose is upgraded
  2. timestamps set to true ( no need to create schema fields for createdAt and updatedAt)

janishar
janishar reviewed Dec 12, 2023
View reviewed changes
Copy link
Owner

@janishar janishar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation will be better if we have schema.set('timestamps', true); with select:false for createdAt and updatedAt in find based queries. These fields should not be returned in query by default. If you can provide this solution then it can be considered for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janishar janishar janishar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashantk01 @janishar